lldbgdbremote.md: Update qWasmLocal result description
#170393
Merged
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current description mistakenly specified that an address of the local value in some address space is returned. When testing this with Wasm runtimes that already implement this command, it can be clearly seen that the value is returned. The value itself may be an address for languages that use shadow stack in Wasm linear memory, but the value of an arbitrary local does not always contain that address.
Member
|
@llvm/pr-subscribers-lldb Author: Max Desiatov (MaxDesiatov) ChangesThe current description mistakenly specified that an address of the local value in some address space is returned. When testing this with Wasm runtimes that already implement this command, it can be clearly seen that the value is returned. The value itself may be an address for languages that use shadow stack in Wasm linear memory, but the value of an arbitrary local does not always contain that address. Full diff: https://github.com/llvm/llvm-project/pull/170393.diff 1 Files Affected:
diff --git a/lldb/docs/resources/lldbgdbremote.md b/lldb/docs/resources/lldbgdbremote.md
index 36b95f1073ebc..80e76fed8c78b 100644
--- a/lldb/docs/resources/lldbgdbremote.md
+++ b/lldb/docs/resources/lldbgdbremote.md
@@ -2505,7 +2505,7 @@ variables.
Get the value of a Wasm function argument or local variable for the given frame
index at the given variable index. The indexes are encoded as base 10. The
-result is a hex-encoded address from where to read the value.
+result is a hex-encoded little-endian value of the local.
```
|
JDevlieghere
reviewed
Dec 2, 2025
Member
JDevlieghere
left a comment
JDevlieghere
left a comment
There was a problem hiding this comment.
You're right, it returns the value, not the address. The documentation for qWasmGlobal and qWasmStackValue is incorrect as well.
JDevlieghere
approved these changes
Dec 3, 2025
Member
JDevlieghere
left a comment
JDevlieghere
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing this!
MaxDesiatov
added a commit
to swiftwasm/WasmKit
that referenced
this pull request
Dec 3, 2025
This change fully implements `qWasmLocal` GDB RP host command per the LLDB extensions specification updated in llvm/llvm-project#170393.
kcloudy0717
pushed a commit
to kcloudy0717/llvm-project
that referenced
this pull request
Dec 4, 2025
The current description mistakenly specified that an address of a local value in some address space is returned. When testing this with Wasm runtimes that already implement this command, it can be observed that the value itself is returned. The value itself may be an address for languages that use shadow stack in Wasm linear memory, but the value of an arbitrary local does not always contain that address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current description mistakenly specified that an address of a local value in some address space is returned. When testing this with Wasm runtimes that already implement this command, it can be observed that the value itself is returned. The value itself may be an address for languages that use shadow stack in Wasm linear memory, but the value of an arbitrary local does not always contain that address.